Fix for situationally broken apropos command #1711 #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You should also update the changelog. |
Contributor
Author
|
I hope that was the changelog you wanted updated? :) |
Contributor
|
@sijis will need to review and merge. I don't have merge permission |
sijis
approved these changes
Mar 11, 2025
Contributor
|
@zaughon thank you! |
Contributor
Author
|
Np, and thank you both as well! :) |
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Apr 21, 2025
…1712) * Fix for situationally broken apropos command errbotio#1711 * Cleanup unused get_name function * Added fix to CHANGES.rst --------- Co-authored-by: Martin Flygenring <[email protected]> Co-authored-by: Sijis Aviles <[email protected]>
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Apr 21, 2025
…1712) * Fix for situationally broken apropos command errbotio#1711 * Cleanup unused get_name function * Added fix to CHANGES.rst --------- Co-authored-by: Martin Flygenring <[email protected]> Co-authored-by: Sijis Aviles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix situationally broken apropos command when
self.bot_config.HIDE_RESTRICTED_COMMANDSwas used.#1711
Additionally removed unused get_name function